-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#8529] RatingsBox #1694
[#8529] RatingsBox #1694
Conversation
6a0c2e3
to
267af3d
Compare
Wait, I guess it doesn't make sense to change it in this PR, I meant, do I have to change it in the mb PR? Or only after this PR is merged so it points to the main branch? |
ea2bf02
to
0d97967
Compare
@vellip we usually update the mb pr with a new commit updating the hash in package.json and requirements/base.xt once the a4 pr is merged |
@vellip sorry, I haven't looked at the changes yet but just for planning the next releases: is this a breaking change, e.g. for regular mb (not dev) and a+ ? If so could you include a note in the changelog (e.g. prefix the changelog entry with |
@vellip ah, sorry, you mentioned that in the PR description already: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks. Will leave for @hom3mad3 as you tested the corresponding mb pr as well. Just left some small comments/questions
@vellip looks great! i'll let you merge after reading the pending comments :) |
0d97967
to
0e1157b
Compare
adapt ratings buttons to have new icons, more modern code and tests, and a functioning redirect when unauthenticated
Tasks
Example of how the render prop can be used
https://github.com/liqd/a4-meinberlin/blob/9199aac9a351a130d84f738f304e210a767221e5/meinberlin/react/budgeting/SupportBox.jsx
A custom rating component that allows only positive ratings. All the UI changes can be handled in meinBerlin and the functionality (redirecting when unauthenticated, REST-API handling of ratings, updating state) stays in a4.
@goapunk not sure anymore, do I have to change the hashes in requirements.txt and package.json in this PR?