Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

projects/TimelinePropertiesMixin: add check if module has a project s… #1525

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

goapunk
Copy link
Contributor

@goapunk goapunk commented Feb 6, 2024

…et to prevent a crash for modules marked as draft

testing: without this fix, if you go to the django-admin -> modules and mark a module as draft and then click on show on website you will get a 500 in multimodule projects (default with the local fixtures).

Tasks

  • PR name contains story or task reference
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

…et to prevent a crash for modules marked as draft
Copy link

github-actions bot commented Feb 6, 2024

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 12.85% 141/1097
🔴 Branches 14.86% 103/693
🔴 Functions 12.54% 44/351
🔴 Lines 20.57% 725/3525

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 5da79a7

@m4ra m4ra merged commit b2a6529 into main Feb 6, 2024
3 checks passed
@m4ra m4ra deleted the jd-2024-02-fix-timeline-crash branch February 6, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants