Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makes send_async serializable for celery workers #1493

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

hklarner
Copy link
Contributor

@hklarner hklarner commented Sep 19, 2023

No description provided.

@hklarner hklarner requested review from goapunk and m4ra September 19, 2023 11:18
@github-actions
Copy link

github-actions bot commented Sep 19, 2023

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 10.48% 120/1145
🔴 Branches 12.13% 89/734
🔴 Functions 10.46% 39/373
🔴 Lines 17.78% 645/3627

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 3427ac4

@hklarner hklarner force-pushed the hk-2023-09-refactors-emails-send-async branch 3 times, most recently from 38fcc0d to ee3635a Compare September 19, 2023 13:26
adhocracy4/emails/tasks.py Outdated Show resolved Hide resolved
@hklarner hklarner force-pushed the hk-2023-09-refactors-emails-send-async branch 2 times, most recently from 41ddb5b to ae157ae Compare September 20, 2023 12:11
adhocracy4/emails/tasks.py Outdated Show resolved Hide resolved
adhocracy4/emails/tasks.py Outdated Show resolved Hide resolved
@hklarner hklarner force-pushed the hk-2023-09-refactors-emails-send-async branch from ae157ae to c27f88f Compare September 20, 2023 13:55
adhocracy4/emails/tasks.py Outdated Show resolved Hide resolved
adhocracy4/emails/tasks.py Outdated Show resolved Hide resolved
adhocracy4/emails/tasks.py Outdated Show resolved Hide resolved
@hklarner hklarner force-pushed the hk-2023-09-refactors-emails-send-async branch from c27f88f to 3427ac4 Compare September 21, 2023 10:10
@hklarner hklarner requested review from m4ra and goapunk September 21, 2023 10:12
@hklarner hklarner changed the title refactors send_async so that it can send data as well as objects makes send_async serializable for celery workers Sep 21, 2023
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will leave for @m4ra to give a final review and merge

@m4ra m4ra merged commit db03f34 into main Sep 21, 2023
2 checks passed
@m4ra m4ra deleted the hk-2023-09-refactors-emails-send-async branch September 21, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants