a4maps: fix map attribution not set for vector tile maps #1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage reportTotal coverage
Report generated by 🧪jest coverage report action from 21a8714 |
goapunk
force-pushed
the
jd-2023-09-fix-vector-map-attribution
branch
2 times, most recently
from
4ab71a5 to
11db8ec
Compare
goapunk
force-pushed
the
jd-2023-09-fix-vector-map-attribution
branch
from
11db8ec to
21a8714
Compare
m4ra
reviewed
Sep 27, 2023
| @@ -101,6 +101,8 @@ export function createMap (L, e, { | |||
| } | |||
| const baselayer = L.tileLayer(basemap, { accessToken }) | |||
| baselayer.addTo(map) | |||
| } | |||
| if (attribution) { | |||
There was a problem hiding this comment.
should be fine. @philli can u confirm?
There was a problem hiding this comment.
looks good, tricky to test for me right now as my local versions of other apps won't currently install this version of a4 but happy to merge and see?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.