Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

userdashboard: use new target_creator to improve filtering #2445

Merged
merged 3 commits into from
May 30, 2023
Merged

userdashboard: use new target_creator to improve filtering #2445

merged 3 commits into from
May 30, 2023

Conversation

goapunk
Copy link
Contributor

@goapunk goapunk commented May 25, 2023 •
edited
Loading

@goapunk goapunk added the Dev: A4 depending PR or issue dependent on A4 label May 25, 2023
@goapunk goapunk requested review from Rineee and fuzzylogic2000 May 25, 2023 09:32
@goapunk goapunk changed the title userdashboard: use new target_creator to improve filtering WIP: userdashboard: use new target_creator to improve filtering May 25, 2023
fuzzylogic2000
fuzzylogic2000 approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Rineee
Rineee approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@Rineee Rineee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Supercool!

@goapunk goapunk changed the title WIP: userdashboard: use new target_creator to improve filtering userdashboard: use new target_creator to improve filtering May 30, 2023
@goapunk goapunk requested review from Rineee and fuzzylogic2000 May 30, 2023 14:46
@Rineee Rineee force-pushed the jd-2023-05-ud-filtering branch from 5c9ea42 to 7d08fbd Compare May 30, 2023 15:44
@github-actions
Copy link

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 12% 84/700
🔴 Branches 13.69% 49/358
🔴 Functions 9.62% 25/260
🔴 Lines 23.23% 528/2273

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from c6da014

@Rineee
Copy link
Contributor

Rineee commented May 30, 2023

yeah, cool!

@Rineee Rineee merged commit e9b596f into main May 30, 2023
@Rineee Rineee deleted the jd-2023-05-ud-filtering branch May 30, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rineee Rineee Awaiting requested review from Rineee

@fuzzylogic2000 fuzzylogic2000 Awaiting requested review from fuzzylogic2000

Assignees
No one assigned
Labels
Dev: A4 depending PR or issue dependent on A4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@goapunk @Rineee @fuzzylogic2000