Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map: remove color from icons in ideas map display #5895

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

vellip
Copy link
Collaborator

@vellip vellip commented Dec 17, 2024

No description provided.

@vellip vellip requested review from m4ra and hom3mad3 and removed request for hom3mad3 December 18, 2024 09:41
@vellip
Copy link
Collaborator Author

vellip commented Dec 18, 2024

@m4ra let me know if we should change the a4 commit hash in this PR directly or not. Regardless it should also be in the release.

@m4ra
Copy link
Contributor

m4ra commented Dec 18, 2024

Yes, please change the commit hash of a4 so PMs can test it in dev @vellip

@vellip
Copy link
Collaborator Author

vellip commented Dec 18, 2024

@m4ra Do you already have a release branch in a4?

@m4ra
Copy link
Contributor

m4ra commented Dec 18, 2024

No, I can do that quickly, one minute

@m4ra m4ra mentioned this pull request Dec 18, 2024
4 tasks
@m4ra
Copy link
Contributor

m4ra commented Dec 18, 2024

@vellip you can update the a4 dependency here with the following liqd/adhocracy4#mB-v2412.2

@vellip
Copy link
Collaborator Author

vellip commented Dec 18, 2024

@m4ra I just did. One second before merging though, because for some reason I still have the aural css class on comments.
CleanShot 2024-12-18 at 12 55 12@2x

@vellip
Copy link
Collaborator Author

vellip commented Dec 18, 2024

@m4ra sorry, I am a bit slow today... somehow the change that I did here liqd/adhocracy4@ae6b657 doesn't seem to be in the a4 dependency of my project after running make install even after setting the release branch as target for install. But maybe that's just a local issue with my installation?

@vellip vellip force-pushed the pv-2024-12-change-caret-icon-in-map branch from 469d0ea to 1954372 Compare December 18, 2024 12:25
@vellip
Copy link
Collaborator Author

vellip commented Dec 18, 2024

should be good now, thanks @m4ra

Copy link
Contributor

@m4ra m4ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I will merge once workflow tests are done.

@m4ra m4ra merged commit 906e0f6 into main Dec 18, 2024
3 checks passed
@m4ra m4ra deleted the pv-2024-12-change-caret-icon-in-map branch December 18, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants