Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update buttons wording and modify submit templates #5718

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

hom3mad3
Copy link
Contributor

@hom3mad3 hom3mad3 commented Oct 10, 2024

update a few strings and expand previously created submit template snippets

@hom3mad3 hom3mad3 requested review from goapunk and vellip October 14, 2024 07:56
Copy link
Collaborator

@vellip vellip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but do you think there is a simple and quick way to document these partials/includes of yours so others know how/ where to use them? Or do you think it's already simple enough?
Feel free to merge otherwise.

@hom3mad3
Copy link
Contributor Author

LGTM, but do you think there is a simple and quick way to document these partials/includes of yours so others know how/ where to use them? Or do you think it's already simple enough? Feel free to merge otherwise.

good idea, it would be a good thing to have a visual reference and the name of the partial. not sure where exactly could be a good place to document this? /docs is very much about the project codebase, but we don't seem to have a place to document the specific components/snippets? @goapunk do you know?

@goapunk
Copy link
Contributor

goapunk commented Oct 14, 2024

@hom3mad3 not that I know of. We could create e.g. a subfolder where we can add docs for components if that suits the purpose? If a visual thing is better we could extend the component library with explanations I guess: https://meinberlin-dev.liqd.net/components/

@hom3mad3
Copy link
Contributor Author

@goapunk @vellip adding it here #5720, wip, as this page needs some TLC

@hom3mad3 hom3mad3 merged commit de1ba2c into dev Oct 14, 2024
3 checks passed
@hom3mad3 hom3mad3 deleted the mr-2024-10-adapt-wording-buttons branch October 14, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants