Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add languages data and endpoint #32

Merged
merged 46 commits into from
Jan 31, 2024
Merged

Add languages data and endpoint #32

merged 46 commits into from
Jan 31, 2024

Conversation

gregdan3
Copy link
Member

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Jan 31, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: fa5201d
Status: ✅  Deploy successful!
Preview URL: https://ada3c63d.sona-f2s.pages.dev
Branch Preview URL: https://languages.sona-f2s.pages.dev

View logs

Comment on lines 5 to 6
name_en = "Standard Arabic"
name_tok = "toki Alapi"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe have these and endonym be fields under a name object?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying this out. It felt a little weird at first, since the hypothetical correct place for endonym is actually [id], but leaving it be seemed fine.

@gregdan3 gregdan3 marked this pull request as ready for review January 31, 2024 17:02
@gregdan3 gregdan3 merged commit b4ae611 into main Jan 31, 2024
3 checks passed
@gregdan3 gregdan3 deleted the languages branch February 12, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants