Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed the default path issue #375

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

pengfeixx
Copy link

Fixed the default path issue
Bug: https://pms.uniontech.com/bug-view-272475.html Log: Fixed the default path issue

Fixed the default path issue
Bug: https://pms.uniontech.com/bug-view-272475.html
Log: Fixed the default path issue
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • checkImmutableMode 函数中使用了 QProcess 来执行外部命令,但没有处理可能的异常情况,例如命令执行失败或输出格式不正确。
  • checkImmutableMode 函数中的 qWarningqInfo 日志应该根据实际需求调整,以避免在生产环境中输出过多的日志信息。
  • setenv 函数在 checkImmutableMode 函数中被调用,但没有检查 getenv("HOME") 是否为空,可能会导致未定义行为。
  • setenv 函数在 main 函数中被调用,但没有检查 getenv("XDG_CURRENT_DESKTOP") 是否为空,可能会导致未定义行为。
  • main 函数中直接修改环境变量 PWD,这可能会影响程序的其他部分,应该考虑是否有更安全或更灵活的方式来处理这种情况。

是否建议立即修改:

@pengfeixx pengfeixx merged commit f1d83d0 into linuxdeepin:release/eagle Nov 29, 2024
15 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pengfeixx, rb-union, starhcq

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pengfeixx pengfeixx deleted the bugfix branch November 29, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants