Skip to content

Commit

Permalink
drm/amd: Make fence wait in suballocator uninterruptible
Browse files Browse the repository at this point in the history
commit e2884fe upstream.

Commit c103a23
("drm/amd: Convert amdgpu to use suballocation helper.")
made the fence wait in amdgpu_sa_bo_new() interruptible but there is no
code to handle an interrupt. This caused the kernel to randomly explode
in high-VRAM-pressure situations so make it uninterruptible again.

Signed-off-by: Simon Pilkington <[email protected]>
Fixes: c103a23 ("drm/amd: Convert amdgpu to use suballocation helper.")
Reviewed-by: Christian König <[email protected]>
Signed-off-by: Christian König <[email protected]>
Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2761
CC: [email protected] # 6.4+
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
SimonPilkington authored and gregkh committed Sep 23, 2023
1 parent 6dc454e commit ecccfc5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/amd/amdgpu/amdgpu_sa.c
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ int amdgpu_sa_bo_new(struct amdgpu_sa_manager *sa_manager,
unsigned int size)
{
struct drm_suballoc *sa = drm_suballoc_new(&sa_manager->base, size,
GFP_KERNEL, true, 0);
GFP_KERNEL, false, 0);

if (IS_ERR(sa)) {
*sa_bo = NULL;
Expand Down

0 comments on commit ecccfc5

Please sign in to comment.