viz: Add HA Option through CLI #5470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds `--ha` flag for `viz install` which overrides with the `values-ha.yaml` of the viz chart. This PR adds these functions in `pkg/charts` so that the same can be re-used elsewhere. Signed-off-by: Tarun Pothulapati <[email protected]>
adleong
reviewed
Jan 5, 2021
kleimkuhler
reviewed
Jan 7, 2021
Comment on lines
+197
to
+215
| // MergeMaps returns the merge result of two maps | ||
| func MergeMaps(a, b map[string]interface{}) map[string]interface{} { | ||
| out := make(map[string]interface{}, len(a)) | ||
| for k, v := range a { | ||
| out[k] = v | ||
| } | ||
| for k, v := range b { | ||
| if v, ok := v.(map[string]interface{}); ok { | ||
| if bv, ok := out[k]; ok { | ||
| if bv, ok := bv.(map[string]interface{}); ok { | ||
| out[k] = MergeMaps(bv, v) | ||
| continue | ||
| } | ||
| } | ||
| } | ||
| out[k] = v | ||
| } | ||
| return out | ||
| } |
There was a problem hiding this comment.
Seems like this should depend #5433 since it adds the same function?
Signed-off-by: Tarun Pothulapati <[email protected]>
cpretzer
approved these changes
Jan 7, 2021
Signed-off-by: Tarun Pothulapati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
--haflag forviz installwhich overrides withthe
values-ha.yamlof the viz chart. This PR adds these functionsin
pkg/chartsso that the same can be re-used elsewhere.Testing
Signed-off-by: Tarun Pothulapati [email protected]