Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracing Add-on For Linkerd #3955
Tracing Add-on For Linkerd #3955
Changes from 12 commits
442c787
6eba3da
a428e96
a4db942
9827600
d6eb6db
c303d02
1bb5fa4
b8f7182
b72b7f8
df90cb3
6f3fa94
89fc1df
94f2340
1347e12
b0e013d
27347ab
048e696
42bffa9
d8bb871
72d1c0d
544660e
86e17bf
0e316bb
1bfcfc6
6fb3f1e
19be7f7
e8629b6
e28efdd
b5f3882
faed2d0
a7acaad
ab8965e
b1fc765
2b90e20
216fdaa
bc5829f
262287d
b9d941b
721b5b4
2f50ee7
8461251
250e0e2
bc32082
12f7b1a
a669666
cb8b486
829ba04
8ef593c
26b28ad
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the
or
here is not needed?Also if tracing is not enabled then
$dupValues
won't be defined. Will that cause a problem down at the end of this file?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This if condition is to not have
linkerd-values
cm to be deployed, when there are zero add-ons enabled. Hence, theor
condition but once we make thelinkerd-values
common for all config, then we should be able to remove this if condition.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a comment to specify the purpose of this configmap? Maybe something like: