Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade dependencies #59

Merged
merged 7 commits into from
May 12, 2022
Merged

upgrade dependencies #59

merged 7 commits into from
May 12, 2022

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented May 7, 2022

closes

prerequisites:

  • branch is up-to-date with the branch to be merged with, i.e. develop
  • build is successful
  • code is cleaned up and formatted

Summary

upgrade dependencies and setup

@sgratzl sgratzl added the chore label May 7, 2022
@sgratzl sgratzl requested a review from thinkh May 7, 2022 18:16
@sgratzl sgratzl self-assigned this May 7, 2022
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general the changes look good. However, I could not build the branch locally anymore. Running yarn run build or yarn run build:dev stalls. See also my comment in the lineupjs PR.

Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build works with Node 16 for me. I've added a comment to the development setup in the README.md.

@sgratzl sgratzl merged commit bafe0eb into develop May 12, 2022
@sgratzl sgratzl deleted the sgratzl/upgrade branch May 12, 2022 17:47
@sgratzl sgratzl mentioned this pull request Jul 26, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants