-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix left side of collapsing row border #40
Conversation
Fixes lineupjs/lineupjs#456 - Uses the updated code example from https://stackoverflow.com/a/28807765 - Modify the top border (= last box shadow part)
The linter seems to have a conditions that exclude each other. If I commit the following Prettier output (formatting on save) ... @mixin collapsing-row-border($border-width, $border-color) {
// use box-shadow to create collapsing border (@see https://stackoverflow.com/a/28807765)
box-shadow: $border-width 0 0 0 $border-color, 0 $border-width 0 0 $border-color,
$border-width $border-width 0 0 $border-color /* Just to fix the corner */, $border-width 0 0 0 $border-color inset,
0 0 0 $border-width $border-color;
} ... the linter complains:
Putting every part in the new line like so... @mixin collapsing-row-border($border-width, $border-color) {
// use box-shadow to create collapsing border (@see https://stackoverflow.com/a/28807765)
box-shadow: $border-width 0 0 0 $border-color,
0 $border-width 0 0 $border-color,
$border-width $border-width 0 0 $border-color /* Just to fix the corner */,
$border-width 0 0 0 $border-color inset,
0 0 0 $border-width $border-color;
} ... returns the following error:
@sgratzl How should I proceed here? Can we either change Prettier or the stylelint config? |
I would change the stylelint config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disabled stylelint for this one line
Fixes lineupjs/lineupjs#456
Summary