Fix rustdoc
example scraping configuration.
#2353
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs.rs failed to build Druid v0.8.0 docs because we were specifying a stale unstable nightly rustdoc option in our
Cargo.toml
.I temporarily disabled this option in #2348.
This PR here brings back example scraping. Unfortunately the rustdoc book is also stale so I had to go deep into the tracking issue to figure out how it changed. The feature can now be disabled on a per example basis, but I enabled it for all of them like was intended before.
I also enabled all the features for docs.rs builds. We used to disable
svg
andimage
due to duplicate artifacts. The duplicate artifacts tracking issue is still open, howeverrustdoc
no longer seems to complain for our builds. Perhaps the code changed or the issue is more limited now? Not sure, but I think we can keep the features enabled for now.I tested this on my own machine with the nightly toolchain and everything seems to work fine.
Critically, I also updated our CI tests. The docs are now built with the nightly toolchain, as that matches docs.rs. I also updated the flags to be a closer match to what docs.rs is configured to use. This way we can hopefully prevent another event where a published build fails on docs.rs. On top of that I made sure we enable our various features in all sorts of CI tests and removed
libx11-dev
as a seemingly stale Linux dependency.