documentation: added instructions for writing gRPC clients in Javascript #125
Conversation
mably
force-pushed
the
topic/grpc-javascript-tutorial
branch
2 times, most recently
from
2446c9f to
2f4d5e4
Compare
mably
force-pushed
the
topic/grpc-javascript-tutorial
branch
from
2f4d5e4 to
b68951c
Compare
Roasbeef
force-pushed
the
master
branch
2 times, most recently
from
d86107c to
a34df2f
Compare
There was a problem hiding this comment.
Thanks for the PR!
I've tested out your tutorial locally and everything seems to be working properly.
As a minor nit, the subsystem prefix on the PR should instead be docs/grpc.
Also, I think it'd be helpful for new comers if we linked to the official gRPC tutorial for Javascript in the documentation: http://www.grpc.io/docs/tutorials/basic/node.html
| I had to comment the following line in the `rpc.proto` file otherwise `grpc` would crash: | ||
|
|
||
| ``` | ||
| //import "google/api/annotations.proto"; |
There was a problem hiding this comment.
Hmm, this looks related to: protobufjs/protobuf.js#433
We can either investigate a direct fix, or just re-word the statement above to be declarative:
In order to use the protos from
js, you'll need to comment out the following line.
|
Thanx @Roasbeef for merging my PR. Simple question, sorry for my ignorance, but what is the PR subsystem prefix you are talking about exactly? |
No description provided.