Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: bump go, cometbft, cosmos-sdk & ignite #66

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

fmorency
Copy link
Contributor

@fmorency fmorency commented Dec 3, 2024

Ignite v28.6.0 is now required to build this project.

MacOS builds were disabled because of btcsuite/btcd#2243 and the need to use the CGO implementation of libsecp256k1.

We can revisit the use of this build tag if cosmos/cosmos-sdk#15018 gets backported to 0.47.x.

@fmorency fmorency self-assigned this Dec 3, 2024
@fmorency fmorency requested a review from jgryffindor December 3, 2024 17:54
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.83%. Comparing base (ab649b8) to head (c95a8aa).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   63.83%   63.83%           
=======================================
  Files          28       28           
  Lines        1117     1117           
=======================================
  Hits          713      713           
  Misses        359      359           
  Partials       45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jgryffindor
Copy link

jgryffindor commented Dec 12, 2024

This caused an AppHash error when upgrading a node from 0.2.2. in dev.
https://gc-dev-rpc.liftedinit.tech/block?height=3881696

[email protected]:26656
Dec 13 16:14:44 d-kvs-200 ghostcloudd[52516]: 4:14PM ERR Error in validation err="wrong Block.Header.AppHash.  Expected A0D193D71801F3759CF7FAAA56ED11E8E466601DC8A5776951E667F1E6FB1A29, got 58C3066EABE2678DE971089B0261B1B128C0D7FD68F387829D4F406FB2C7FEB6" module=blockchain
Dec 13 16:14:44 d-kvs-200 ghostcloudd[52516]: 4:14PM ERR Stopping peer for error err="Reactor validation error: wrong Block.Header.AppHash.  Expected A0D193D71801F3759CF7FAAA56ED11E8E466601DC8A5776951E667F1E6FB1A29, got 58C3066EABE2678DE971089B0261B1B128C0D7FD68F387829D4F406FB2C7FEB6" module=p2p peer="Peer{MConn{143.198.33.16:26656} 8a06177b6b9d94358057d2a56eb5046fc2831fc7 out}"

@jgryffindor
Copy link

Also errored out in running a second attempt on the testnet:
https://gc-testnet-rpc.liftedinit.tech/block?height=5160787

Dec 13 16:44:49 d-kvs-103 ghostcloudd[727800]: 4:44PM INF service start impl=TimeoutTicker module=consensus msg="Starting TimeoutTicker service"
Dec 13 16:44:49 d-kvs-103 ghostcloudd[727800]: 4:44PM INF resetting proposal info height=5160787 module=consensus proposer=B4503C8B639E0F6524C360D8837C9DDD964DA24B round=1
Dec 13 16:44:49 d-kvs-103 ghostcloudd[727800]: 4:44PM INF commit is for a block we do not know about; set ProposalBlock=nil commit=A4E0A4509BE29BD8EFBB7E51E55048898BE3A9EDF1D7B06D16C67A80B0741636 commit_round=1 height=5160787 module=consensus proposal=
Dec 13 16:44:49 d-kvs-103 ghostcloudd[727800]: 4:44PM INF received complete proposal block hash=A4E0A4509BE29BD8EFBB7E51E55048898BE3A9EDF1D7B06D16C67A80B0741636 height=5160787 module=consensus
Dec 13 16:44:49 d-kvs-103 ghostcloudd[727800]: 4:44PM ERR CONSENSUS FAILURE!!! err="+2/3 committed an invalid block: wrong Block.Header.AppHash.  Expected E9926235362C9E798132A0A4BBB5DC22289065475211AED44338D8FAE70E5DA1, got DCF84029ABF84A605F7E3CB7C7E6A6D8F419F63C1EEBFAEE1D522025E6E32F4D" module=consensus stack="goroutine 209 [running]:\nruntime/debug.Stack()\n\t/usr/local/go/src/runtime/debug/stack.go:26 +0x5e\ngithub.com/cometbft/cometbft/consensus.(*State).receiveRoutine.func2()\n\t/home/circleci/go/pkg/mod/github.com/cometbft/[email protected]/consensus/state.go:737 +0x46\npanic({0x216fbc0?, 0xc010ff1f60?})\n\t/usr/local/go/src/runtime/panic.go:785 +0x132\ngithub.com/cometbft/cometbft/consensus.(*State).finalizeCommit(0xc0005e0008, 0x4ebf53)\n\t/home/circleci/go/pkg/mod/github.com/cometbft/[email protected]/consensus/state.go:1651 +0xfb3\ngithub.com/cometbft/cometbft/consensus.(*State).tryFinalizeCommit(0xc0005e0008, 0x4ebf53)\n\t/home/circleci/go/pkg/mod/github.com/cometbft/[email protected]/consensus/state.go:1620 +0x2e8\ngithub.com/cometbft/cometbft/consensus.(*State).handleCompleteProposal(0xc0005e0008, 0x4ebf53)\n\t/home/circleci/go/pkg/mod/github.com/cometbft/[email protected]/consensus/state.go:2016 +0x372\ngithub.com/cometbft/cometbft/consensus.(*State).handleMsg(0xc0005e0008, {{0x2f51320, 0xc0104518d8}, {0xc000c09a40, 0x28}})\n\t/home/circleci/go/pkg/mod/github.com/cometbft/[email protected]/consensus/state.go:847 +0x167\ngithub.com/cometbft/cometbft/consensus.(*State).receiveRoutine(0xc0005e0008, 0x0)\n\t/home/circleci/go/pkg/mod/github.com/cometbft/[email protected]/consensus/state.go:773 +0x3f1\ncreated by github.com/cometbft/cometbft/consensus.(*State).OnStart in goroutine 150\n\t/home/circleci/go/pkg/mod/github.com/cometbft/[email protected]/consensus/state.go:384 +0x10c\n"
Dec 13 16:44:49 d-kvs-103 ghostcloudd[727800]: 4:44PM INF service stop impl=baseWAL module=consensus msg="Stopping baseWAL service" wal=/home/many/.ghostcloud/data/cs.wal/wal
Dec 13 16:44:49 d-kvs-103 ghostcloudd[727800]: 4:44PM INF service stop impl=Group module=consensus msg="Stopping Group service" wal=/home/many/.ghostcloud/data/cs.wal/wal
Dec 13 16:44:53 d-kvs-103 ghostcloudd[727800]: 4:44PM INF Timed out dur=3500 height=5160787 module=consensus round=1 step=RoundStepPropose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants