feat: faq via cms #56
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SI-809 FAQ via CMS
Integrate FAQ from CMS to ETH staking widget. For this needs:
|
Jeday
requested changes
Oct 2, 2023
DiRaiks
reviewed
Oct 11, 2023
Jeday
requested changes
Oct 11, 2023
DiRaiks
reviewed
Oct 11, 2023
Preview stand statusStand was demolished |
Jeday
requested changes
Dec 18, 2023
DiRaiks
reviewed
Dec 18, 2023
Jeday
previously approved these changes
Dec 26, 2023
DiRaiks
previously approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrate FAQ package for all pages FAQ (works with Next SRR, Client Side, IPFS version).
Matomo:
Events to matomo send by another way (actual only for code review).
A matomo event generated by template
<project_name>_faq_<page_id>_<question_id>_<link_content>For example for
Request tablink: event will beeth_widget_faq_Withdrawals_Claim_How_Do_I_Withdraw_Request_tabFAQ content to CMS
see PR:
Stake Page: Update Ethereum Staking Widget “faq-stake-page” lido-content#66
Wrap Page: Update Ethereum Staking Widget “faq-wrap-and-unwrap-page” lido-content#68
Withdrawals Page Claim: Update Ethereum Staking Widget “faq-withdrawals-claim-page” lido-content#69
Withdrawals Page Request: Update Ethereum Staking Widget “faq-withdrawals-request-page” lido-content#70
Code review notes
Needs approve new matomo event in all
FAQblocks with @mariyamuziko, 'cause now they are generated by template.Needs add all
FAQblocks content to https://github.com/lidofinance/lido-content via Lido CMS. More info you can find by me (@solidovic) or @mariyamuzikoCheck a both using of
modeandfaqListandrevalidateingetStaticPropsonpages/wrap/[[...mode]].tsx.Testing notes
Needs to click all links on
FAQblocks and make sure events send to Matomo.Check on IPFS version.
Related PRs
questionIdfield to faqWidget preview lido-cms#27UPDATE: after we decided that wants split FAQ by page:
Checklist: