Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: RUSTSEC-2024-0421 by upgrading idna #5727

Merged
merged 5 commits into from
Dec 11, 2024
Merged

fix: RUSTSEC-2024-0421 by upgrading idna #5727

merged 5 commits into from
Dec 11, 2024

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Dec 10, 2024 •
edited
Loading

Description

https://rustsec.org/advisories/RUSTSEC-2024-0421.html

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

hanabi1224
hanabi1224 commented Dec 10, 2024
View reviewed changes
Cargo.lock Show resolved Hide resolved
hanabi1224
hanabi1224 commented Dec 10, 2024
View reviewed changes
Cargo.lock Show resolved Hide resolved
@hanabi1224 hanabi1224 marked this pull request as ready for review December 10, 2024 01:22
@hanabi1224 hanabi1224 mentioned this pull request Dec 10, 2024
Closed
2 tasks
@hanabi1224 hanabi1224 force-pushed the fix-RUSTSEC-2024-0421 branch from 24178a6 to 56d48fb Compare December 10, 2024 07:22
elenaf9
elenaf9 reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@elenaf9 elenaf9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hanabi1224!

Two nits, rest lgtm.

protocols/mdns/Cargo.toml Outdated Show resolved Hide resolved
transports/dns/Cargo.toml Outdated Show resolved Hide resolved
transports/dns/src/lib.rs Outdated Show resolved Hide resolved
elenaf9
elenaf9 previously approved these changes Dec 10, 2024
View reviewed changes
jxs
jxs previously approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@jxs jxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jxs jxs added the send-it label Dec 11, 2024
@mergify mergify bot dismissed stale reviews from elenaf9 and jxs December 11, 2024 11:41

Approvals have been dismissed because the PR was updated after the send-it label was applied.

@mergify mergify bot merged commit cda1470 into libp2p:master Dec 11, 2024
70 of 71 checks passed
@hanabi1224 hanabi1224 deleted the fix-RUSTSEC-2024-0421 branch December 11, 2024 12:50
@AurelienFT AurelienFT mentioned this pull request Dec 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxs jxs jxs approved these changes

@elenaf9 elenaf9 elenaf9 left review comments

Assignees
No one assigned
Labels
send-it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanabi1224 @jxs @elenaf9