-
Notifications
You must be signed in to change notification settings - Fork 978
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gossipsub): implement gossipsub 1.2 beta #5697
base: master
Are you sure you want to change the base?
feat(gossipsub): implement gossipsub 1.2 beta #5697
Conversation
This pull request has merge conflicts. Could you please resolve them @hopinheimer? 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hopinheimer!
Couple of comments.
I think the new protocol version also needs to be added to the ProtocolConfig
?
Hi @elenaf9 thank you for the review, I have made all the requested changes although, there seem to be a test that's failing |
I think it has to do something with
The test can be fixed by using a different I was actually wondering if it was on purpose that |
Description
This PR implements gossipsub 1.2 beta bringing changes over from lighthouse
ref PR: sigp/lighthouse#5422
Please include any relevant issues in here, for example:
libp2p/specs#548