Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the various unimplemented!() from the code #295

Closed
tomaka opened this issue Jul 11, 2018 · 1 comment
Closed

Remove the various unimplemented!() from the code #295

tomaka opened this issue Jul 11, 2018 · 1 comment
Labels
priority:important The changes needed are critical for libp2p, or are blocking another project

Comments

@tomaka
Copy link
Member

tomaka commented Jul 11, 2018

Right now it's possible to crash a server running libp2p by triggering one of the unimplemented!() of the code base.

Either an error should be returned, or the feature should be implemented.
@tomaka tomaka added the priority:important The changes needed are critical for libp2p, or are blocking another project label Jul 11, 2018
twittner added a commit to twittner/rust-libp2p that referenced this issue Jul 11, 2018
@twittner
multiaddr: mark ONION as TODO
07a492e 
Addresses libp2p#295
@twittner twittner mentioned this issue Jul 11, 2018
Closed
@tomaka tomaka mentioned this issue Jul 13, 2018
Merged
@romanb
Copy link
Contributor

romanb commented Jul 11, 2019

After #1089 is resolved by #1189, I guess this issue can be closed, as I can find no other occurrences of unimplemented besides two in core-drive which seem irrelevant for this issue.

@tomaka tomaka closed this as completed Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:important The changes needed are critical for libp2p, or are blocking another project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@romanb @tomaka