metrics: provide separate docker-compose files for OSX and Linux #2397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
reviewed
Jun 27, 2023
Comment on lines
+10
to
+12
| extra_hosts: # define a host.docker.internal alias, so we can use the same datasources.yml and prometheus.yml on Linux and OSX | ||
| - "host.docker.internal:127.0.0.1" | ||
| grafana: |
There was a problem hiding this comment.
This needs to be the gateway address(172.17.0.1), right?
https://docs.docker.com/compose/compose-file/compose-file-v3/#extra_hosts
There was a problem hiding this comment.
Unfortunately that doesn't work. Kubo is only listening on 127.0.0.1 for the metrics endpoint.
There was a problem hiding this comment.
Got it. I missed the line above it. This will work with this network_mode: "host"
MarcoPolo
approved these changes
Jun 28, 2023
Co-authored-by: Marco Munizaga <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2387.
I wish there was a better way to do this, but I can't figure out.
Any idea how to test this end-to-end in CI? Would be great if we could set up a node and check that the swarm dashboard shows a connection, but I don't want to build a HTML parser.