Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix some comments errors #2356

Merged
merged 2 commits into from
Jun 13, 2023
Merged

docs: fix some comments errors #2356

merged 2 commits into from
Jun 13, 2023

Conversation

sysvm
Copy link
Contributor

@sysvm sysvm commented Jun 12, 2023

No description provided.

@sysvm sysvm force-pushed the docs/fixcomments branch from ef20108 to f03c8b0 Compare June 12, 2023 15:40
marten-seemann
marten-seemann previously requested changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of incorrect suggestions here.

config/config.go Outdated Show resolved Hide resolved
core/crypto/secp256k1.go Show resolved Hide resolved
core/event/network.go Show resolved Hide resolved
core/network/network.go Outdated Show resolved Hide resolved
core/network/rcmgr.go Show resolved Hide resolved
core/record/envelope.go Outdated Show resolved Hide resolved
@sysvm
Copy link
Contributor Author

sysvm commented Jun 13, 2023 •
edited
Loading

What does this sentence mean? I think it uses incorrect words. Link
image

@sysvm sysvm force-pushed the docs/fixcomments branch from 884553e to 0e74d67 Compare June 13, 2023 14:12
@marten-seemann
Copy link
Contributor

@p-shahi Could you help review this PR please?

@marten-seemann marten-seemann requested a review from p-shahi June 13, 2023 14:19
p-shahi
p-shahi approved these changes Jun 13, 2023
View reviewed changes
core/crypto/secp256k1.go Show resolved Hide resolved
core/network/rcmgr.go Show resolved Hide resolved
@p-shahi
Copy link
Member

p-shahi commented Jun 13, 2023

What does this sentence mean? I think it use incorrect words. Link image

Modus operandi is a Latin phrase: https://en.wikipedia.org/wiki/Modus_operandi
The comment in the screenshot is fine as is.

Thanks for doing this, not the most critical change but grammatical corrections are appreciated

@sysvm
Copy link
Contributor Author

sysvm commented Jun 13, 2023

What does this sentence mean? I think it use incorrect words. Link image

Modus operandi is a Latin phrase: https://en.wikipedia.org/wiki/Modus_operandi The comment in the screenshot is fine as is.

Thanks for doing this, not the most critical change but grammatical corrections are appreciated

Got it, thanks!

@p-shahi p-shahi dismissed marten-seemann’s stale review June 13, 2023 17:43

Some comments addressed, others lgtm as is. Marten verbally gave ok to dismiss this review

@p-shahi p-shahi merged commit b4c9fed into libp2p:master Jun 13, 2023
@sysvm sysvm deleted the docs/fixcomments branch June 14, 2023 03:45
@MarcoPolo MarcoPolo mentioned this pull request Jul 14, 2023
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p-shahi p-shahi p-shahi approved these changes

@marten-seemann marten-seemann marten-seemann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sysvm @marten-seemann @p-shahi @yzhaoyu