feat: update to go-libp2p-core 0.7.0 interface changes #1001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vyzo
reviewed
Sep 2, 2020
Stebalien
added
the
status/blocked
|
Blocked on fixing an issue with multistream. |
Stebalien
force-pushed
the
feat/rw-stream
branch
from
9691336 to
dd87884
Compare
Stebalien
force-pushed
the
feat/rw-stream
branch
2 times, most recently
from
7a7d3a5 to
b33cbc7
Compare
Stebalien
removed
the
status/blocked
Stebalien
added a commit
to libp2p/go-libp2p-gostream
that referenced
this pull request
Nov 2, 2020
Stebalien
added a commit
to ipfs/go-graphsync
that referenced
this pull request
Nov 2, 2020
Stebalien
added a commit
to ipfs/go-graphsync
that referenced
this pull request
Nov 2, 2020
This was referenced Nov 2, 2020
Stebalien
added a commit
to libp2p/go-libp2p-gostream
that referenced
this pull request
Nov 2, 2020
aschmahmann
approved these changes
Nov 9, 2020
p2p/net/mock/mock_stream.go
Outdated
| } | ||
|
|
||
| func (s *stream) Close() error { | ||
| s.CloseRead() |
There was a problem hiding this comment.
do we need _ = to satisfy the linter?
There was a problem hiding this comment.
We don't have that linter here, but it can't hurt.
| @@ -26,7 +25,7 @@ func (ids *IDService) deltaHandler(s network.Stream) { | |||
| return | |||
| } | |||
|
|
|||
| defer helpers.FullClose(s) | |||
| defer s.Close() | |||
There was a problem hiding this comment.
what qualifies as requiring a reset? e.g. does failing to consume the delta warrant a reset?
There was a problem hiding this comment.
Yes. Although the other end likely isn't listening for an error.
Comment on lines
-283
to
+292
| func (s *stream) resetWith(err error) { | ||
| func (s *stream) cancelWrite(err error) { |
There was a problem hiding this comment.
Are there any test changes downstream that would be effected by this change?
There was a problem hiding this comment.
I believe I needed this to fix an issue in the bitswap tests.
Stebalien
force-pushed
the
feat/rw-stream
branch
from
c34fc5a to
fd6ec7d
Compare
This patch updates go-libp2p for the stream interface changes in go-libp2p-core 0.7.0. This is a _significant_ breaking change to streams and all users should read https://github.com/libp2p/go-libp2p-core/releases/tag/v0.7.0. In practice, this change should remove a significant footgun. TL;DR: * `Stream.Close` now behaves like `net.TCPConn.Close`. * There is a new `Stream.CloseWrite` (send an EOF) and `Stream.CloseRead` (close for reading), behaving like their counterparts in `net.TCPConn`.
Stebalien
force-pushed
the
feat/rw-stream
branch
from
fd6ec7d to
7a98f28
Compare
Stebalien
added a commit
to libp2p/go-libp2p-gostream
that referenced
this pull request
Nov 12, 2020
marten-seemann
pushed a commit
that referenced
this pull request
Aug 29, 2023
gts2030
pushed a commit
to superblock-dev/go-libp2p
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates go-libp2p for the stream interface changes in go-libp2p-core 0.7.0. This is a significant breaking change to streams and all users should read https://github.com/libp2p/go-libp2p-core/releases/tag/v0.7.0. In practice, this change should remove a significant footgun.
TL;DR:
Stream.Closenow behaves likenet.TCPConn.Close.Stream.CloseWrite(send an EOF) andStream.CloseRead(close for reading), behaving like their counterparts innet.TCPConn.Dependencies:
Bubbling: