Synchronous openRepository Fails

[djrenren]

I try opening a repository like so:

var repo =  gitteh.openRepository(".git");

and receive:

node_modules/gitteh/lib/args.js:33
     throw new Error("Not enough arguments.");
Error: Not enough arguments.

[mildsunrise]

Starting with 0.17.1, synchronous operations are now disabled.
For more info, see #51.

[mildsunrise]

@samcday [duplicate of #51] [close request]

[samcday]

@jmrenner, what @jmendeth said ;) Synchronous operations aren't just disabled, they were never re-implemented when I did a big refactor of the codebase for 0.17. I decided not to implement synchronous behavior again as it makes the codebase much more complex. Apologies for any inconvenience this might have caused you!

[mildsunrise]

@samcday That remembers me, when compatibility is broken in such a way,
the major version should be bumped. So we should have 1.0.0 now.

[djrenren]

Awesome, no problem! We should probably update the docs though.

[mildsunrise]

@jmrenner Yeah, that's #53.

[samcday]

@jmendeth technically we're allowed to get away with breaking changes between "minor" releases in semver when the major version is still 0. I really wanna keep gitteh versioning tracking libgit2, as it feels more intuitive (at least to me)

Sent from my iPhone

On 20/07/2013, at 18:34, "Xavier Mendez" [email protected] wrote:

@jmrenner Yeah, that's #53.

—
Reply to this email directly or view it on GitHub.

[mildsunrise]

👍 didn't know that.

2013/7/20 Sam [email protected]

@jmendeth technically we're allowed to get away with breaking changes
between "minor" releases in semver when the major version is still 0. I
really wanna keep gitteh versioning tracking libgit2, as it feels more
intuitive (at least to me)

Sent from my iPhone

On 20/07/2013, at 18:34, "Xavier Mendez" [email protected]
wrote:

@jmrenner Yeah, that's #53.

—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/61#issuecomment-21292700
.