-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should this be check_symbol_exists instead of check_prototype_exists? #732
Comments
Well, to my eye it looks right. One finds prototypes in headers and symbols in libraries. Do you have a patch that works better? |
responding to libgeos#732
created pull request #742 |
Oh sry I got you wrong in the first place. What I intended to say is, like in Line 207 in b602db5
isn't it looking for a symbol in a header? |
Yes, that one seems odd. |
History seems to have caught up with this issue, I see neither test in the code base anywhere anymore. |
geos/CMakeLists.txt
Line 196 in b602db5
should we use in this line check_symbol_exists instead of check_prototype_exists since we are searching in C headers instead of in c++ headers, just like searching for isfinite in line 207?
The text was updated successfully, but these errors were encountered: