Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should this be check_symbol_exists instead of check_prototype_exists? #732

Closed
yurikoif opened this issue Nov 11, 2022 · 5 comments
Closed

Comments

@yurikoif
Copy link

check_prototype_exists(isnan math.h HAVE_ISNAN)

should we use in this line check_symbol_exists instead of check_prototype_exists since we are searching in C headers instead of in c++ headers, just like searching for isfinite in line 207?

@pramsey
Copy link
Member

pramsey commented Nov 14, 2022

Well, to my eye it looks right. One finds prototypes in headers and symbols in libraries. Do you have a patch that works better?

yurikoif added a commit to yurikoif/geos that referenced this issue Nov 24, 2022
@yurikoif
Copy link
Author

created pull request #742

@yurikoif
Copy link
Author

Oh sry I got you wrong in the first place. What I intended to say is, like in

check_symbol_exists(isfinite math.h HAVE_ISFINITE)

isn't it looking for a symbol in a header?

@pramsey
Copy link
Member

pramsey commented Nov 24, 2022

Yes, that one seems odd.

@pramsey
Copy link
Member

pramsey commented Mar 10, 2023

History seems to have caught up with this issue, I see neither test in the code base anywhere anymore.

@pramsey pramsey closed this as completed Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants