dark mode maps #23
Closed
dark mode maps #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
should probably change the plane icon to a lighter one when in dark mode?
Update index.html
Closed
|
perfect, thank you! will try it soon, but don't see any issues why i wouldn't merge it. yea, different color would be nice. i also want to add other planes and need a different color (and size) for them anyways. you thing a plane svg would work, think we can change the color then easily. |
|
cherry-picked/merged your changes to master, will be in the next release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hope you're happy with a PR
I saw a couple of requests for dark mode, so here is a quick suggestion to add cartodb dark themed maps
should probably change the plane icon to a lighter one when in dark mode?