Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pip install padl in notebooks #329

Closed
wants to merge 19 commits into from
Closed

Conversation

jasonkhadka
Copy link
Member

Description

Part of #324
Makes notebook complete with installation of padl.

@sjrl sjrl linked an issue Dec 15, 2021 that may be closed by this pull request
5 tasks
@sjrl
Copy link
Contributor

sjrl commented Dec 15, 2021

@jasonkhadka Could you also add all additional requirements that need to be installed? For example, pip install matplotlib. If they are commented out, then just uncomment then. The goal is to be able to click run all and just to have it work.

@sjrl
Copy link
Contributor

sjrl commented Dec 15, 2021

Additionally, could you see if the instructions on how to download and access the data need to be updated to reflect the colab environment?

@sjrl
Copy link
Contributor

sjrl commented Dec 15, 2021

@sjrl sjrl mentioned this pull request Dec 15, 2021
5 tasks
README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
@sjrl
Copy link
Contributor

sjrl commented Dec 15, 2021

Last thing @jasonkhadka. Do you think it's worth uncommenting the other pip install dependencies in the notebooks? Otherwise looks good!

@jasonkhadka
Copy link
Member Author

Last thing @jasonkhadka. Do you think it's worth uncommenting the other pip install dependencies in the notebooks? Otherwise looks good!

yeah, i think so, I am testing the colab notebook, also regards to data.
I will update the notebooks once again with the changes so they can run directly on colab.

@jasonkhadka jasonkhadka requested a review from sjrl December 15, 2021 15:48
@jasonkhadka
Copy link
Member Author

Now, notebooks can run on colab directly.
For sentiment analysis, kaggle data needs to be downloaded, so users will have to do that on their own. Except all good.

@jasonkhadka jasonkhadka requested a review from sjrl December 15, 2021 16:20
@wuhu
Copy link
Contributor

wuhu commented Dec 15, 2021

@jasonkhadka

kaggle data needs to be downloaded, so users will have to do that on their own. Except all good.

would it be possible to add that to the notebook also? I think we should make it as easy as possible to use that.

@sjrl
Copy link
Contributor

sjrl commented Dec 15, 2021

@jasonkhadka

kaggle data needs to be downloaded, so users will have to do that on their own. Except all good.

would it be possible to add that to the nodebook also? I think we should make it as easy as possible to use that.

We could use the kaggle api for this potentially. https://stackoverflow.com/questions/49386920/download-kaggle-dataset-by-using-python

import kaggle

kaggle.api.authenticate()

kaggle.api.dataset_download_files('The_name_of_the_dataset', path='the_path_you_want_to_download_the_files_to', unzip=True)

@jasonkhadka
Copy link
Member Author

You need your kaggle account to authenticate against kaggle api to download the files.

I will check if there is another way, else anther easy way is to add the data to PADL repo. It seems it is not that big.

@jasonkhadka

kaggle data needs to be downloaded, so users will have to do that on their own. Except all good.

would it be possible to add that to the nodebook also? I think we should make it as easy as possible to use that.

We could use the kaggle api for this potentially. https://stackoverflow.com/questions/49386920/download-kaggle-dataset-by-using-python

import kaggle

kaggle.api.authenticate()

kaggle.api.dataset_download_files('The_name_of_the_dataset', path='the_path_you_want_to_download_the_files_to', unzip=True)

@jasonkhadka
Copy link
Member Author

@sjrl @wuhu Sentiment140 dataset can be directly downloaded on colab now.

@sjrl
Copy link
Contributor

sjrl commented Dec 16, 2021

Thanks @jasonkhadka!

@codecov-commenter
Copy link

codecov-commenter commented Dec 17, 2021

Codecov Report

Merging #329 (685d196) into main (fe7fe5d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #329   +/-   ##
=======================================
  Coverage   89.46%   89.46%           
=======================================
  Files          15       15           
  Lines        2572     2572           
=======================================
  Hits         2301     2301           
  Misses        271      271           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe7fe5d...685d196. Read the comment docs.

@jasonkhadka
Copy link
Member Author

issues on GoogleColab to track progress on python update:
Upgrade Ubuntu: googlecolab/colabtools#1880
Upgrade Python: googlecolab/colabtools#2165

@jasonkhadka
Copy link
Member Author

closed until Colab is updated.

@sjrl sjrl mentioned this pull request Jan 19, 2022
@sjrl sjrl deleted the notebook_update branch February 11, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add notebooks to Google Colab
4 participants