Replace codespell with typos

[szepeviktor]

From #7241

[szepeviktor]

@aarongable Am I doing it right?

[aarongable]

Thanks, this is definitely on the right track!

When I build this docker image and then run typos, I get the following error:

typos: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by typos)
typos: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.33' not found (required by typos)
typos: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by typos)

Looks like the base image we're copying the typos binary into doesn't have the right version of libc. If you fix that, this change will LGTM

[szepeviktor]

Looks like the base image we're copying the typos binary into doesn't have the right version of libc. If you fix that, this change will LGTM

Added static linking!
crate-ci/typos#903 (comment)

[pgporada]

I have a potential solution for this. See my changes to the Dockerfile and a new file used by the Dockerfile called build-rust-deps.sh.

What's happening here is the chosen rust container for the docker multipart build, rust:bookworm has a newer GLIBC than the container that we actually run commands from, letsencrypt/boulder-tools, which is based on Ubuntu Focal. This means we get the errors that @aarongable mentioned above.

$ docker run -it rust:bookworm bash
# dpkg -l | grep libc6
ii  libc6:amd64                        2.36-9+deb12u3                 amd64        GNU C Library: Shared libraries
ii  libc6-dev:amd64                    2.36-9+deb12u3                 amd64        GNU C Library: Development Libraries and Header Files

$ docker run -it letsencrypt/boulder-tools:go1.21.5_2024-01-17 bash
# dpkg -l | grep libc6
ii  libc6:amd64                2.31-0ubuntu9.14                  amd64        GNU C Library: Shared libraries
ii  libc6:amd64                2.31-0ubuntu9.14                  amd64        GNU C Library: Shared libraries

A newer GLIBC can run binaries requiring an older GLIBC (to an extent), but not the other way around which is this case. Even with static linking I think there would be a problem. So what can we do? Can we instruct the rust compiler to target a specific version of GLIBC? No, we cannot. Alright, so let's use an Ubuntu Focal official rust container. Sorry, not currently possible. All hope is lost right? I mean, yeah probably, but not for this issue! We can use an older Debian Bullseye container that contains a suitable GLIBC!

$ docker run -it rust:bullseye bash
# dpkg -l | grep libc6
ii  libc6:amd64                        2.31-13+deb11u7                amd64        GNU C Library: Shared libraries
ii  libc6-dev:amd64                    2.31-13+deb11u7                amd64        GNU C Library: Development Libraries and Header Files

This solution works on both x86_64 and Apple Silicon M1/M2/M3 Macbooks.

# uname -a
Linux 264571b4fe9f 6.6.6-76060606-generic #202312111032~1702306143~22.04~d28ffec SMP PREEMPT_DYNAMIC Mon D x86_64 x86_64 x86_64 GNU/Linux

# typos -h
Source Code Spelling Correction

Usage: typos [OPTIONS] [PATH]...

# uname -a
Linux b3f20d997b18 6.5.11-linuxkit #1 SMP PREEMPT Wed Dec  6 17:08:31 UTC 2023 aarch64 aarch64 aarch64 GNU/Linux

# typos -h
Source Code Spelling Correction

Usage: typos [OPTIONS] [PATH]...

[beautifulentropy]

Thanks @pgporada, I've confirmed, as you state above, that this works on my Mac equipped with Apple Silicon.

[szepeviktor]

rust:bullseye

Implemented 🍏

[pgporada]

I suggest taking the rest of the changes my branch has for the Dockerfile and the new build-rust-deps.sh script.

[szepeviktor]

@pgporada Could you open a new PR from your branch?

I get Pull request creation failed. Validation failed: must be a collaborator

[pgporada]

Sure. I would have just copied and pasted the files.