Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Non-DI] Page Elements Not Displayed Correctly following their switch to ajax player like DI #68

Closed
Nzzyme opened this issue Apr 17, 2023 · 2 comments
Closed

[Non-DI] Page Elements Not Displayed Correctly following their switch to ajax player like DI #68

Nzzyme opened this issue Apr 17, 2023 · 2 comments
Labels
enhancement

Comments

@Nzzyme
Copy link

Nzzyme commented Apr 17, 2023

Hi, I installed your script and observed that some elements do not display correctly (only checked on radiotunes). See screenshot below:

image

Elements like skip, volume bar, loop track, download, etc. do not display correctly. Can you please check and fix?
@lethak
Copy link
Owner

lethak commented Apr 17, 2023

Actually this is a big deal, they just adopted the DI player on non DI sites.
I will have to adapt the script

@lethak lethak changed the title Page Elements Not Displayed Correctly [Non-DI] Page Elements Not Displayed Correctly following their switch to ajax player like DI Apr 19, 2023
lethak added a commit that referenced this issue Apr 21, 2023
@lethak
v2023.4.92
91e531a 
* Adapted the userscript to take into account new UI/UX of non-DI sites now using an ajax navigation and audio player, similar to DI always had. #68
* Player(track download button): Added the download track button for responsive/mobile small screen size.
* Channels & Playlists (Unlock): Improving the unlock mechanism for UI/UX purposes, still imperfect. #66
* Channels & Playlists (trackHistoryPlayButton): Fixed a bug where the play button would not render (DI only).
* Track hero page(play button): Added a custom play button as the native one is not always present. Still, it can suffer from the same problems discussed in issue #66.
* Registration wall: localStorage is now cleared automatically followed by a full page reload if you had already reached the listening limit prior to using the bypass feature.
@lethak lethak closed this as completed Apr 21, 2023
@Nzzyme
Copy link
Author

Nzzyme commented Apr 21, 2023

Thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lethak @Nzzyme