Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume ramp-up is not interruptible #54

Closed
Tremolo4 opened this issue Apr 9, 2021 · 2 comments
Closed

Volume ramp-up is not interruptible #54

Tremolo4 opened this issue Apr 9, 2021 · 2 comments

Comments

@Tremolo4
Copy link

Tremolo4 commented Apr 9, 2021

Sometimes, the volume is (re-)set e.g. to 80% from 25% when I open di.fm. Not sure why (it was already happening before the recent update).

Thankfully, the userscript makes sure that the radio does not immediately blare at 80% when I press play thanks to the volume ramp-up feature. However, it is hopeless to try and adjust the volume before it has ramped up to 80% -- it just keeps going up. I have to take off my headphones quickly, wait until it has ramped up to 80%, turn it down, then put my headphones back on.

Idea for a fix: It would be nice if the ramp-up cancels once you start adjusting the volume.

@lethak
Copy link
Owner

lethak commented Apr 9, 2021

Hi,
It will be in the next release,
thanks for the suggestion !

@Tremolo4
Copy link
Author

Tremolo4 commented Apr 9, 2021

Wow, thanks a lot! Looking forward to it.

And also thanks a lot for this script in general :)

lethak added a commit that referenced this issue Feb 9, 2022
All platforms:
* Player (volume ease up): The user can now interrupt the volume from increasing by manually adjusting it at the same time (issue #54)
* Greasy Forks: Added readme.md and updatable script version that redirect users to the readme.

di-only:
* Upvoted tracks playback (Loop button):  Fixed broken CSS on the loop button (issue #55)
@lethak lethak closed this as completed Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants