Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViolentMonkey problem with download #36

Closed
crzsotona opened this issue Jul 27, 2020 · 6 comments
Closed

ViolentMonkey problem with download #36

crzsotona opened this issue Jul 27, 2020 · 6 comments

Comments

@crzsotona
Copy link

Hello,

LTKDIFMU on Violentmonkey cannot download files, it opens as binary blob instead, could you investigate please?

@lethak
Copy link
Owner

lethak commented Jul 28, 2020

Hi,

At first glance and without investigating much it appears VM do not support the 'saveAs' option.

I know of no solution yet unless not using GM_download with VM,

I will look to do this for the next version of the script using GM_info

link & sources:

EDIT:

For future research into the subject:

Workaround

Use tempermonkey

@lethak lethak added the bug label Jul 28, 2020
@ReflexivR
Copy link

ReflexivR commented Aug 8, 2020

So tampermonkey works OK downloading still?

@ReflexivR
Copy link

Just checked and tampermonkey works great downloading still. There's really no benefit to running violentmonkey, right? I would just tell users to switch. Thanks for your script!

@ReflexivR
Copy link

Downloads do appear to be mp4 rather than mp3 files though. Is this intended?

@lethak
Copy link
Owner

lethak commented Aug 8, 2020

Yeah don't worry about that, it will still work anyway. The actual format is the one you are listening and depends on the audio quality of your free/premium account.

@lethak
Copy link
Owner

lethak commented Oct 4, 2020

On the next release:

Reverted to old track download method when NOT using Tampermonkey

Those users will be reverted back to the old ways of downloading via window.open(url).
It means those users will not be able to have an automatic normalized file name for the time being, but can still manually download.

Tampermonkey users are not impacted.

lethak added a commit that referenced this issue Oct 14, 2020
…e/v2020.10.642)

🎉 This release is now having every feature envisioned when starting this little script, with more added along the way ! 🎉

All platforms:
* Userscript (meta): Added some @grant directives like GM_setValue and GM_getValue in order to save user preferences & script settings regardless of localStorage
limitations. This will likely require an agreement click from the user when tampermonkey updates the script to this version.
* Userscript (UI): Added a new custom UI screen to manage script settings and feature oup-out. Accessible via the "DIUserscript" menu entry for each site. (issue #15)
* Userscript (initialization): Fixed a case where the script would not load properly into the page when the DOM was already loaded.
* Player (browser global media controls): Added support for navigator.mediaSession, making Global Media Controls available with skip and previous track buttons. (issue
* Player (play previous track button): Fixed a bug where the button would not show up or work as intended while listening to 'Playlists' episodes.
* Player (play previous track button): Converted to VueJS component.
* Player (volume input control): Converted to VueJS component.
* Player (track download button): Adjusted CSS
* Player (track download button): reverted to old track download method when NOT using Tampermonkey. It means those users will not be able to have an automatic
normalized file name for the time being, but can still manually download. (issue #36)
* Documentation: Updated README, Troubleshooting and Disclaimer/FAQ pages

di-only:
* Navigation (UI): Added the "DIUserscript" menu entry for responsive mobile version and small displays.

Non-DI platforms:
* Premium Channels: This new feature will try to unlock otherwise paywalled channels by fooling the client's audio player into thinking you are entilted.
* Visual ads: Removed new "premium" & "trial" slideshow carousel
* Player (play previous track button): Fixed disappearance (issue #42)
* Player (volume input control): Fixed bad CSS alignment (issue #43)
* Navigation (UI): Fixed the "DIUserscript" menu entry not appearing properly.
@lethak lethak closed this as completed Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants