Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert canopy to use sizzle selector engine instead of normal WebDriver... #98

Merged
merged 1 commit into from
Sep 4, 2013

Conversation

gkinsman
Copy link
Contributor

@gkinsman gkinsman commented Sep 3, 2013

Converts canopy to use the sizzle selector engine instead of normal the WebDriver By.CssSelector using the SizSelCsZzz library.

Note that it's currently using Sizzle 1.6.2 - my next task is to submit a pull request to update it.

@lefthandedgoat
Copy link
Owner

Let me spend some time running my tests suites and regressing and I will accept. Tonight probably.

lefthandedgoat added a commit that referenced this pull request Sep 4, 2013
Convert canopy to use sizzle selector engine instead of normal WebDriver...
@lefthandedgoat lefthandedgoat merged commit 69fd007 into lefthandedgoat:master Sep 4, 2013
@lefthandedgoat
Copy link
Owner

This is fixed and is now available in canopy 0.8.3 available on nuget,

@gkinsman
Copy link
Contributor Author

gkinsman commented Sep 4, 2013

Thanks for the very timely pull!

@lefthandedgoat
Copy link
Owner

Thanks for the contribution! I had to implement it a little differently because BySizzle.CssSelector seemed to be case sensitive, and By.CssSelector seems to not be, and I didn't want to break anyone's existings tests. The effect should be the same though.

@gkinsman
Copy link
Contributor Author

gkinsman commented Sep 4, 2013

That's interesting...I was wondering what the practical difference between ByJquery and BySizzle was. I've no idea why that would be the case, but good catch.

@lefthandedgoat
Copy link
Owner

I dont know the difference between Jquery and Sizzle, I assume Jquery provides a super set of selectors. I was referring to Sizzle vs Seleniums By.CssSelector for case sensitive vs case in-sensitive. I did a good bit of reading about sizzle and jquery, couldn't find an answer, so I added both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants