Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #505
This is what I had in mind to make
runFor
more reliable. It still clones the suites for each browser so that the context is still specific to the browser, but does not add an extra suite to do the browser switching so that running suites in different order doesn't break it.Types of changes
What types of changes does your code introduce to canopy?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
Unfortunately it still doesn't satisfactorily show an error if the browser fails to start.
If an exception occurs when starting a browser, then failSuite is run on all suites for that browser instead of running the tests.
But
failSuite
runsfail
withautoFail
set to true, just skipping all the tests and nothing actually fails.What is the point of
autoFail
? Isn't the whole point of failSuite to report all the tests as failed (it's not skipSuite...) #178?I'm hesitant to just just remove
autoFail
altogether because I don't understand why it was added.