Add fail if any wip tests config setting & docs #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. I will try to get a build done today. I have a few more changes that I need to get in also but haven't started working on. Thanks! |
|
Thanks, you can find your changes here: https://www.nuget.org/packages/canopy/1.5.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently in the project I'm working on I've committed changes with some canopy tests still marked as wip. This isn't easy to notice as the CI build has gone on to pass but only one or two tests were actually run.
The idea here is to prevent against accidentally pushed commits with wip marked tests by eagerly failing the build. The setting would be off by default but switched on in CI.
I don't know if using
raiseis the right way to fail but I'm assuming it would work.