Added support for Safari, changes required to run canopy on OSX and Linux(mono) #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added Safari to the available browsers - Path for the drivers are is now different depending on the OS
|
We needed to run automated tests on Safari for OSX, so I made small changes to support that. There is a small trick to test Safari on OSX, to run tests on Safari, you need to have the Chrome Driver and the file name must be "chromedriver.exe", by default the Chrome driver for OSX does not have the ".exe" extension so you need to add it. |
|
Nice, I actually develop on OSX and use the same chromedriver.exe trick. I will accept and make some minor changes. I will try to get a new build out for you tonight. Thanks! |
lefthandedgoat
added a commit
that referenced
this pull request
Aug 25, 2015
Added support for Safari, changes required to run canopy on OSX and Linux(mono)
|
Great!, thanks to you |
|
Available for download here: https://www.nuget.org/packages/canopy/0.9.32 Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested changes on Windows(Chrome, IE, FireFox and Safari), Linux(Firefox and Chrome), OSX(Safari, Firefox, Chrome)