Make on (url) checks for equality against full and partial (sans Query string) urls #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discussed on this gist: https://gist.github.com/KevM/6554377#comment-906673 Note: this is a breaking change with the existing on as it does a compare and was passing for sub partial urls.
|
Thanks! I will try to get a new build out tonight. |
lefthandedgoat
added a commit
that referenced
this pull request
Sep 16, 2013
Make on (url) checks for equality against full and partial (sans Query string) urls
|
I haven't forgotten, just been busy, sorry. |
|
No worries. I already have a solution to side load Canopy when needed. ⛵ |
|
Now in 0.8.7. Thanks for the contribution and sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed on this gist: https://gist.github.com/KevM/6554377#comment-906673
The last test may be overkill. ⛵
Note: this is a breaking change with the existing on as it does a compare and was passing for sub partial urls.