Having a long timeout results in StackOverflowException

[ghost]

Our application has a pretty long startup time. Therefore I have to set the timeouts to a value bigger than 1 minute. If I now run multiple tests in parallel (with different AppDomains in the same dll) sometimes a StackOverflowException is thrown.

Would it be possible to do the waiting in wait.fs without the recursion?

[lefthandedgoat]

I must have not written it in a way to where the tail call optimization kicks in.

What timeout setting causes the StackOverflow? If I can repro I can fix it.

[ghost]

Ok, that was a bit harder to properly reproduce but here is an example where the tail call optimization doesn't work and the stack trace gets longer and longer.

using System.IO;
using canopy;
using _ = canopy.csharp.canopy;

namespace CanopyTest
{
    public class Program
    {
        public static void Main(string[] args)
        {
            configuration.chromeDir = Directory.GetCurrentDirectory();
            configuration.elementTimeout = 30;
            _.start(types.BrowserStartMode.Chrome);

            _.url("https://www.w3schools.com/css/css_display_visibility.asp");
            _.click("#panel");

            _.run();
            _.quit();
        }
    }
}

The problem only occurs when the element is not visible. If it's not there at all then the stack trace is small.

I'm not sure though if this really solves my problem as there is no stack trace is available when a StackOverflow exception happens. But this might cause it.

[lefthandedgoat]

I will try to re-order the recursive calls so that the tail call optimization works and it never causes a stack overflow. Thanks for the repro!

[lefthandedgoat]

I moved to a loop instead of recursion which should fix the StackOverflowException. It also cleans up the exception to not have the same message repeated over and over.

https://www.nuget.org/packages/canopy/1.5.3

[forki]

@lefthandedgoat can you try to apply same thing to canopy.mobile? I see SOs from time to time

[ghost]

Thanks for the update!
Looks good to me now.

[forki]

Latest Canopy.Mobile is also fixed. Awesome