Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopping auto screen capture for failing tests #215

Closed
galatrash opened this issue Sep 30, 2015 · 8 comments
Closed

Stopping auto screen capture for failing tests #215

galatrash opened this issue Sep 30, 2015 · 8 comments

Comments

@galatrash
Copy link

Sometimes I want to stop the automatic screenshots after some tests fail. Is there a flag to disable these in the middle of test contest?

The scenario I'm using is installing a web site then performing some tests on it. If the installation process fails, I set a flag to fail fast and check this flag at the beginning of each tests and fail the test right away. So taking screen shots for all the tests is meaningless. Another useful feature to add is to allow skipping all tests without running them by setting a flag after a specific test fails.

@lefthandedgoat
Copy link
Owner

Ok I can work on these features

@lefthandedgoat
Copy link
Owner

Can you expand on this?

Another useful feature to add is to allow skipping all tests without running them by setting a flag after a specific test fails.

Right now I have a flag called 'failFast' that will stop running any tests after any tests fails.

You would like an additional flag that is similar, but instead of not running more tests, it marks subsequent tests as skipped?

@galatrash
Copy link
Author

Thanks Chris for following up and adding these features.

Yes, this is exactly what I meant: instead of me checking this in each subsequent test, this flag will be utilized by the canopy core and not the tests themselves. Also, there could be another flag for the context scope (skipping all subsequent tests in a context).

lefthandedgoat added a commit that referenced this issue Oct 5, 2015
@lefthandedgoat
Copy link
Owner

I have the changes here:

a5705ca

I reviewed them and I tested them. If you want to review that would be great. If things look right I will do a build.

lefthandedgoat added a commit that referenced this issue Oct 13, 2015
@lefthandedgoat
Copy link
Owner

I dont know if messages are going back and forth correctly with email, because they are not showing up here, so I will put it here instead.

I looked at your diff, but do not know how to apply it, so I manually made similar changes.

You can review here: 679cfd4?diff=split

I dont have a team city instance setup locally to test the changes, but as long as testIgnore is the right TC keyword, it should work.

Let me know and I will do a nuget build.

@galatrash
Copy link
Author

I received the emails but didn't find them in GitHub. I checked the diff view and you had all the changes. I think it is good to go - I've tested and seen these reported as ignored in TeamCity. Please create a nuget package for these.

lefthandedgoat added a commit that referenced this issue Oct 13, 2015
@lefthandedgoat
Copy link
Owner

@galatrash
Copy link
Author

Many thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants