Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail screenshots are taken too late #209

Closed
edmellum opened this issue Aug 17, 2015 · 3 comments
Closed

Fail screenshots are taken too late #209

edmellum opened this issue Aug 17, 2015 · 3 comments

Comments

@edmellum
Copy link

I'm working with a test suite where we login to a web app in our before and logout in after. When a test fails we're seeing that the screenshot that gets taken is taken after the after function is run, not right after the test failed. That means every single screenshot we get after a test has failed is of the login screen as we have just logged out.

After a little exploratory debugging the problem seems to be here. The finally block is run before the pattern match that runs fail which takes the screenshot.

I wrote a little user story too, in case my explanation above wasn't clear enough. 😃

As a tester. When a test fails I want a screenshot of the condition the browser is in at the closest possible moment to the test failing. So that I can debug the failing test.

@lefthandedgoat
Copy link
Owner

Thank you for filling the issue. I will look at it as soon as I can. Hopefully tonight.

@lefthandedgoat
Copy link
Owner

This is fixed and available https://www.nuget.org/packages/canopy/0.9.31

Let me know if you have any other issues. Thanks for opening this issue!

@edmellum
Copy link
Author

Wow great work! 😄

Hopefully I'll get confident enough with the project that I'll submit a PR right away myself next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants