Skip to content

Commit

Permalink
Build error was fixed:
Browse files Browse the repository at this point in the history 
"The primary reference "SizSelCsZzz" could not be resolved because it has an indirect dependency on the assembly "Newtonsoft.Json, Version=4.5.0.0, Culture=neutral, PublicKeyToken=30ad4fe6b2a6aeed" which was built against the ".NETFramework,Version=v4.5" framework. This is a higher version than the currently targeted framework ".NETFramework,Version=v4.0"."
  • Loading branch information
@sergey-tihon
sergey-tihon committed Apr 13, 2014
1 parent 58213e2 commit 170afdd
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
6 changes: 3 additions & 3 deletions src/canopy/canopy.fsproj
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0" encoding="utf-8"?>
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="4.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
Expand All @@ -13,7 +13,7 @@
<Name>canopy</Name>
<SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\</SolutionDir>
<RestorePackages>true</RestorePackages>

<TargetFSharpCoreVersion>4.3.0.0</TargetFSharpCoreVersion>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
<DebugSymbols>true</DebugSymbols>
Expand Down Expand Up @@ -70,7 +70,7 @@
</Reference>
<Reference Include="mscorlib" />
<Reference Include="Newtonsoft.Json">
<HintPath>..\packages\Newtonsoft.Json.6.0.1\lib\net40\Newtonsoft.Json.dll</HintPath>
<HintPath>..\..\packages\Newtonsoft.Json.5.0.1\lib\net40\Newtonsoft.Json.dll</HintPath>
<Private>True</Private>
</Reference>
<Reference Include="SizSelCsZzz">
Expand Down
2 changes: 1 addition & 1 deletion src/canopy/packages.config
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<packages>
<package id="Newtonsoft.Json" version="6.0.1" targetFramework="net40" />
<package id="Newtonsoft.Json" version="5.0.1" targetFramework="net40" />
<package id="Selenium.Support" version="2.41.0" targetFramework="net40" />
<package id="Selenium.WebDriver" version="2.41.0" targetFramework="net40" />
<package id="SizSelCsZzz" version="0.3.35.0" targetFramework="net40" />
Expand Down
1 change: 1 addition & 0 deletions src/sampleprojectstructure/sampleprojectstructure.fsproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
<Name>sampleprojectstructure</Name>
<SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\</SolutionDir>
<RestorePackages>true</RestorePackages>
<TargetFSharpCoreVersion>4.3.0.0</TargetFSharpCoreVersion>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
<DebugSymbols>true</DebugSymbols>
Expand Down
1 change: 1 addition & 0 deletions tests/basictests/basictests.fsproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
<Name>basictests</Name>
<SolutionDir Condition="$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'">..\</SolutionDir>
<RestorePackages>true</RestorePackages>
<TargetFSharpCoreVersion>4.3.0.0</TargetFSharpCoreVersion>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|x86' ">
<DebugSymbols>true</DebugSymbols>
Expand Down

5 comments on commit 170afdd

@lefthandedgoat
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we have 4.3.0.0 then it doesn't work in vs 2010 (Cant even use the nuget package). Will it not work at all without this change?

@lefthandedgoat
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

<TargetFSharpCoreVersion>4.3.0.0</TargetFSharpCoreVersion>

@sergey-tihon
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without this VS2013 could not compile projects(For example I cannot compile code from master branch). As I know F# 3.0 cannot be used inside VS2010. If you want to support VS2010 you need to switch to F# 2.0. Do you really want to support VS2010?

@lefthandedgoat
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is atleast one guy out there who uses it.

#137

I will see if I can use the

<Choose>
    <When Condition="'$(VisualStudioVersion)' == '11.0'">

tags in the solution and make it work. I have all three versions of VS installed and will mess with it more later today. Thanks!

@sergey-tihon
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we can create another solution and project files for VS2010 and tries to build in using F# 2.0 and .Net 2.0.
Potentially we can tune build scripts to build NuGet package that contains both versions. Look at Framework Version Folder Structure in NuGet docs.

Please sign in to comment.