Standardizing Validator Functions for Object props #12921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Coach
| validator(val) { | ||
| return val.name && val.id && val.baseurl; | ||
| }, | ||
| validator: objectValidator({ |
There was a problem hiding this comment.
Where is objectValidator coming from here?
There was a problem hiding this comment.
#8878 Hello, I was following the structure mentioned in this PR!
There was a problem hiding this comment.
I think what @nucleogenesis means is that you will need to import this function from somewhere.
These are the functions available for import, for example:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request focuses on standardizing the validation logic for Object-type props across several components in the Kolibri project by replacing ad-hoc validators with a reusable objectValidator utility. This improves consistency, documentation, and error reporting for these props.
…
References
Related Issue: #8903
…
Reviewer guidance
Check each affected component (FacilityAdminCredentialsForm.vue, NotificationCard.vue, GroupRow.vue, and SelectGroup.vue) to ensure they correctly reject invalid Object props and accept valid ones.
…