-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve issue #267 #283
Resolve issue #267 #283
Conversation
One more thing that can be added is a try-catch for the older version of torchvision. |
Thanks for this PR @nightlessbaron! Yes, catching the exception for older versions is a good idea. Some more comments from a quick glance at the code:
Let me know when it's ready for a full review, and thanks again. |
@seba-1511, thanks for your review. I have incorporated the changes you suggested. |
@nightlessbaron, this looks great and looks ready to merge -- thanks for persisting! Do you want to add a line to CHANGELOG.md and credit yourself? |
Thanks, @seba-1511, it's done. |
Description
Fixes #267
As discussed with @seba-1511, adds an option for RGB bands for Random Rotation.
Contribution Checklist
If your contribution modifies code in the core library (not docs, tests, or examples), please fill the following checklist.