New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a link that jumps to module source to #find_home #17

Merged

adomani merged 1 commit into main from go-to-module

Jul 7, 2024

Contributor

Vtec234 commented Jul 6, 2024 •

edited

Loading

Uses a widget message in #find_home so that the suggested module can be directly jumped to. This was proposed on Zulip.

Some questions I would be grateful for help with:

The widget is just a link that can be clicked. In particular, one doesn't need to ctrl-click. Is this inconsistency with standard go-to-def interactions okay?
GoToModuleLink is a rather specific widget. Should it instead be generalized along some number of axes (for instance to allow jumping to other things besides modules) and put in batteries?
Are there other places in import-graph where a go-to-click would be nice to add?


          feat: add a link that jumps to module source to #find_home

42d7236

Vtec234 force-pushed the go-to-module branch from 9d88400 to 42d7236 Compare

July 6, 2024 19:09

Collaborator

adomani commented Jul 7, 2024

Thanks: I tested it a little and it works great!

adomani merged commit 68b518c into main

2 checks passed

adomani deleted the go-to-module branch

July 7, 2024 15:00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet