feat: support pull_request_target #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The pull_request_target type uses the source code from the base ref of
the pull request, not the contents of the pull request. When GitHub
Actions runs this type, the secret given to the action has write
permissions even when the pull request is from a forked repository. With
the pull_request type, the secret only has read access due to security
concerns.
By allowing a consumer of the action to use pull_request_target, they
can now close issues when a pull request from a fork fixes an issue
too.
Example:
```yaml
on:
pull_request_target:
types: [closed]
```
Signed-off-by: Carolyn Van Slyck <[email protected]>
ldez
force-pushed
the
pull_request_target
branch
from
4bde9e9 to
78be2d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull_request_target type uses the source code from the base ref of the pull request, not the contents of the pull request. When GitHub Actions runs this type, the secret given to the action has write permissions even when the pull request is from a forked repository. With the pull_request type, the secret only has read access due to security concerns.
By allowing a consumer of the action to use pull_request_target, they can now close issues when a pull request from a fork fixes an issue too.
Example: