Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for macOS Apple Silicon #7342

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

robd003
Copy link

@robd003 robd003 commented Dec 11, 2021

Currently this is building x64 and arm64 electron apps.
We could make DMGs of each and have end users select their platform.

Fixes

Issue Number: #7338

What is the current behavior?

Only x64 builds for macOS

What is the new behavior?

x64 & arm64 builds for macOS

Other information

PR Checklist

Toggle...

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I added a line describing my change to CHANGELOG.md
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

@jessopb
Copy link
Member

jessopb commented Dec 11, 2021

Nice - thanks for trying this.
"electron-updater": "^4.2.4", needs to be 4.3.7, some threads say.

@robd003 robd003 force-pushed the master branch 2 times, most recently from 8b79fdd to 7b805e4 Compare December 11, 2021 02:38
@robd003
Copy link
Author

robd003 commented Dec 11, 2021

Todo:

@jessopb
Copy link
Member

jessopb commented Dec 11, 2021

Cool. I'm going to create my own branch of this and PR it so that CI will run.
I'm not terribly satisfied with our ability to test updates yet, but we'll see. I think we have to change 'rc' to 'alpha' in our versions and use a flag that allows using prereleases.

@robd003
Copy link
Author

robd003 commented Dec 11, 2021

@jessopb If you want I can add you to my fork as a contributor so you can push any changes there

https://github.com/robd003/lbry-desktop/invitations

@jessopb
Copy link
Member

jessopb commented Dec 11, 2021

I thikn if I push it, CI will run with the appropriate secrets? I'm not sure why it failed last time.

@robd003
Copy link
Author

robd003 commented Dec 11, 2021

Quick note for building universal app:

import { makeUniversalApp } from '@electron/universal';

await makeUniversalApp({
  x64AppPath: 'dist/electron/mac/LBRY.app',
  arm64AppPath: 'dist/electron/mac-arm64/LBRY.app',
  outAppPath: 'dist/electron/mac-universal/LBRY.app',
});

@jessopb
Copy link
Member

jessopb commented Dec 13, 2021

I think what I'm going to do is add a settings feature that allows people to enable prerelease autoupdates. We'll release that when we get this CSC thing ironed out for windows, then we'll do this as a prerelease that can be e2e tested.

@robd003
Copy link
Author

robd003 commented Dec 14, 2021

@jessopb any chance you could nudge somebody on the team to take a look at this lbryio/lbry-sdk#3516 ?

@jessopb
Copy link
Member

jessopb commented Dec 15, 2021

Yep, done. There was mention of it this morning at meeting.

Currently it's building x64 and arm64 electron apps.
We *could* make DMGs of each and have end users select their
platform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants