Add Plugin Update Checker #1121
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topi314
requested changes
Dec 18, 2024
| @@ -65,6 +65,7 @@ dependencies { | |||
| implementation(libs.kotlin.reflect) | |||
| implementation(libs.logback) | |||
| implementation(libs.sentry.logback) | |||
| implementation(libs.semver) | |||
There was a problem hiding this comment.
is this lib really needed? we already have a way to parse semver in
you would just need to add a method to compare them which should be easy
There was a problem hiding this comment.
Oh I didnt see this thanks!
Comment on lines
+99
to
+118
| val connection = URL(basePath).openConnection() as HttpURLConnection | ||
| connection.inputStream.bufferedReader().use { | ||
| val lines = it.readLines() | ||
| for (line in lines) { | ||
| val regex = "<latest>(.*?)</latest>".toRegex() | ||
| val match = regex.find(line) | ||
| val latest = match?.groups?.get(1)?.value | ||
| if (latest != null) { | ||
| val latestVersion = latest.toVersion() | ||
| val currentVersion = declaration.version.toVersion() | ||
|
|
||
| if(latestVersion > currentVersion) { | ||
| log.warn("A newer version of ${declaration.name} was found: $latestVersion. " + | ||
| "The current version is $currentVersion.") | ||
| } else { | ||
| log.info("Plugin ${declaration.name} is up to date") | ||
| } | ||
| break | ||
| } | ||
| } |
There was a problem hiding this comment.
Can you please not regex XML?
With #1049 we want to parse the maven-metadata.xml anyway
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a plugin update checker function to
PluginManager.ktthat runs on application startupCloses #1044
The function checks the maven repository of each plugin declaration and searches the maven metadata file for the latest version. If then compares the latest version and current version installed and writes to the console if the user needs to update. The 3rd party library "semver" is used as a dependency to compare versions.