Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update all deps #2370

Closed
Closed

Conversation

spencerbart
Copy link

No description provided.

@spencerbart
Copy link
Author

Based on deps.rs there are a lot of out-of-date and potentially insecure dependencies.

https://deps.rs/crate/sqlx/0.6.2

https://deps.rs/crate/sqlx-core/0.6.2

@paolobarbolini
Copy link
Contributor

paolobarbolini commented Feb 23, 2023

Bumping patch versions, or minor versions for >=1.x dependencies, inside Cargo.toml doesn't make sense except in very specific cases like disallowing vulnerable versions or fixing the minimum supported version of a dependency in general. The rest can be done with cargo update

@abonander
Copy link
Collaborator

I have learned the hard way that sweeping dependency upgrades can unexpectedly break things if you're not careful.

@spencerbart please reduce the scope of this PR to just the upgrades that aren't covered by a cargo update.

@abonander
Copy link
Collaborator

Closing due to inactivity.

@abonander abonander closed this Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants