feat: Turborepo build-scripts rebase #661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: change docs package.json private to false fix: build:docs fix: testing suite required jest-environment-jsdom with newer versions of jest refactor: run tests through turbo chore: turbo other tasks
chore: remove quotes around "private" chore: run sort-package-json chore: seems like vercel might need this path chore: clean up changes, make install scripts hidden chore: remove extra code from turbo file chore: sleepy rebase
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
thank you! will take a closer look at this once #633 lands
this pattern is useful when we're all operating out of the same repo to help determine who the branch was created by/owned by |
|
oops, this closed automatically since I merged the base branch |
Merged
|
continuing this over at #669 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently renaming a branch with the github web console closes the old pull request and thread. Just wanted to follow the convention of the repo by putting my username as the starting token of the branch.
Relevant pull requests
#657
#644
Suggestion to make a rebase to this branch
#644 (comment)
Also a heads up - commit 60e62eb broke some of the
hardhatdoc generation. Converting certain packages to modules causes some compilation errors. There is a thread here with some claims support is coming soon.