Skip to content
This repository has been archived by the owner on Aug 26, 2022. It is now read-only.

add support for enum in a message #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

purtato
Copy link
Contributor

@purtato purtato commented Nov 30, 2021

I noticed that nested messages don't seem to be supported #1

So for now i've changed the goal of this PR to make it such that any .proto prior to #63 that was previously working, should still continue to work

The above caveat is explicit because while

message A {
  message B {
    enum C {
      ....
    }
  }
}

will not work, it should at the very least not make things worse

@purtato
Copy link
Contributor Author

purtato commented Dec 6, 2021

also should note that

message A {
  enum C{}
}

message B {
  enum C{}
}

will cause a conflict, prepending the enum name with the message name could make this less likely but isn't guarenteed conflict free
e.g.

message AB {
  enum C{}
}

message A {
  enum BC{}
}

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant